Handle invalid numeric entity references individually#181
Draft
CodingFeng101 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The previous implementation wrapped the whole regex substitution in one
tryblock. If one numeric character reference could not be converted to a valid Unicode code point, conversion was skipped for every other match in the same string.For example,
Ž �produced381-9999999999, even though the first reference is valid and should becomez.Checks
python -m pytest -q-> 84 passedpython -m mypy-> Success: no issues found in 5 source filespython -m pycodestyle --ignore=E128,E261,E225,E501,W605 slugify test.py setup.pygit diff --check